Fix Ruby 4.0 compatibility: replace CGI with URI in DirectFileStore #330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CGI.parse and CGI.escape were removed in Ruby 4.0. Use URI.decode_www_form and URI.encode_www_form instead. Signed-off-by: Danila Poyarkov <dev@dannote.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CGI.parse and CGI.escape methods were removed from the
cgigem in Ruby 4.0. Thecgigem now only providesCGI.escape/CGI.unescapefor HTML escaping, andCGI.escapeURIComponent/CGI.unescapeURIComponentfor URI components.This PR replaces:
CGI::parse(query_string)→URI.decode_www_form(query_string).to_hCGI::escapein query string building →URI.encode_www_formThe
urimodule is part of Ruby's standard library and doesn't require an additional dependency.Testing: